Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transport + storage changes #903

Merged
merged 17 commits into from
Jun 12, 2020
Merged

Transport + storage changes #903

merged 17 commits into from
Jun 12, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jun 11, 2020 •
edited
Loading

Addresses [#816]

  1. Silences all exceptions thrown in storage.py
  2. Changes default storage_path to tmpdirectory + 'opencensus-python' + ikey
  3. Adds a more descriptive warning on request timeout to AI endpoint
  4. Move transport tests into their own module
  5. Disable pylint, too many unsolved warnings.

@lzchen lzchen changed the title Omit OSError on race case in maintenance routine Transport + storage changes Jun 11, 2020
@lzchen lzchen requested review from c24t, reyang, songy23 and a team as code owners June 11, 2020 20:56
@lzchen lzchen mentioned this pull request Jun 11, 2020
Open
@lzchen lzchen requested a review from hectorhdzg June 11, 2020 23:55
@lzchen lzchen merged commit 7ec4ff6 into census-instrumentation:master Jun 12, 2020
@lzchen lzchen deleted the storage branch June 12, 2020 01:35
This was referenced Jun 17, 2020
Merged
Merged
@lzchen lzchen mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@c24t c24t Awaiting requested review from c24t

@reyang reyang Awaiting requested review from reyang

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @hectorhdzg @googlebot